Add test to handle array array string type outputs bios 557 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkeward
requested changes
Nov 29, 2024
Contributor
hkeward
left a comment
hkeward
left a comment
There was a problem hiding this comment.
{
"current_run_output": [["pass", "pass"], ["pass", "pass"]],
"validated_output": [["pass", "pass", "pass", "pass"]]
}This will pass in this test, despite being potentially very different outputs (arrays are of different lengths, for one). Flattening is removing some of the info that needs to be compared.
| # Check if two arrays of arrays of strings are identical by comparing the flattened arrays | ||
| # Input type: Array[Array[String]] | ||
|
|
||
| task validate_and_compare_pbsv_splits { |
Contributor
There was a problem hiding this comment.
Tasks in this repo should be generic and apply to any outputs of the given type - this may be a typo, but the task here should be named the same as the file itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.