Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes qmos segfaults #5556

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

amystamile-usgs
Copy link
Contributor

geos 3.12 switches up the order of polygon coordinates. This caused issues with PolygonTools::FixSeam's algorithm. Running normalized reorganizes the polygons into normal form.

Description

Related Issue

closes #5539

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks fine. Just waiting for tests to come back

@amystamile-usgs
Copy link
Contributor Author

The following tests FAILED:

4966 | 538 - isis2gml_app_test_case01 (Failed)
4967 | 539 - isis2gml_app_test_case02 (Failed)
4968 | 540 - isis2gml_app_test_lincsinc (Failed)

Will look into these today.

@amystamile-usgs
Copy link
Contributor Author

@acpaquette I confirmed that the tests are expected failures due to change in order of polygon coordinates. I checked that the footprints are identical to the current truthdata. I was gonna convert isis2gml to gtests but this would require having to set up an xml reader. For now, I can just update the truth data.

@amystamile-usgs amystamile-usgs merged commit 38dc45e into DOI-USGS:dev Jul 25, 2024
1 check passed
@github-actions github-actions bot added the bug Something isn't working label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qmos - Seg faults only under isis8.2.0-RC#
2 participants