FastAPI app #27
FastAPI app #27
Conversation
| ets: Annotated[list[float], Query()] | str | None = None, | ||
| startEts: float | None = None, | ||
| exposureDuration: float | None = None, | ||
| numOfExposures: int | None = None, |
There was a problem hiding this comment.
Maybe Im missing something, but isn't it better to make a new endpoint rather than adding to the existing one? Im not 100% sure what would be the better practice.
There was a problem hiding this comment.
I thought so too, but I've tried that and found that FastAPI doesn't seem to support having duplicate endpoints with varying query params. Seems like the general consensus was to have one endpoint with either optional params and data validation (example) or create two models (one ets only, other with startEts etc.) where the input data can be validated that way (example).
There was a problem hiding this comment.
I think this approach isn't bad 🤔 thinking about it over the weekend. I think I prefer it over another endpoint with a different name.
These files will standup a local instance of SpiceQL as a FastAPI app. There is a
READMEto follow as well. The endpoints mirror the existing endpoints of the SpiceQL-AWS instance.