Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial switch to httr2 #738

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
030edf4
First steps in switching to httr2
ldecicco-USGS Oct 23, 2024
84cb3cc
Getting there!
ldecicco-USGS Oct 24, 2024
ffbfaa3
udpates from main
ldecicco-USGS Oct 24, 2024
a8f236e
update ua
ldecicco-USGS Oct 24, 2024
ea8170a
start
ldecicco-USGS Oct 24, 2024
d829f26
Merge branch 'main' of https://code.usgs.gov/water/dataRetrieval into…
ldecicco-USGS Nov 1, 2024
6062607
cleaning up WQP calls
ldecicco-USGS Nov 1, 2024
af0b523
style
ldecicco-USGS Nov 1, 2024
f1bbab0
getting the lists correct
ldecicco-USGS Nov 2, 2024
993a2a4
More NWIS and WQP httr2 updates
ldecicco-USGS Nov 3, 2024
9fca4e2
a few httr2 updates
ldecicco-USGS Nov 4, 2024
313fdda
Fixing some tests. Mostly arguments in the URLs are shuffled around.
ldecicco-USGS Nov 4, 2024
f09bb35
wrong argument
ldecicco-USGS Nov 4, 2024
90cb26c
More tests to fix and update findNLDI
ldecicco-USGS Nov 4, 2024
746d32c
local file tests
ldecicco-USGS Nov 4, 2024
47e35a7
getting water use URLs to work
ldecicco-USGS Nov 5, 2024
790f924
more test url updates
ldecicco-USGS Nov 5, 2024
82318a9
everything except NGWMN working
ldecicco-USGS Nov 5, 2024
9792060
NGWMN
ldecicco-USGS Nov 5, 2024
111feb5
Dropping problimatic example (data source keeps changing)
ldecicco-USGS Nov 5, 2024
6bfc32a
Upstream pull
ldecicco-USGS Nov 5, 2024
d289745
adding count=no to legacy
ldecicco-USGS Nov 5, 2024
7ad1ed5
updating docker file
ldecicco-USGS Nov 5, 2024
20fa9e7
run check on develop
ldecicco-USGS Nov 5, 2024
8f93afe
Fix test due to my last minute addition of count=no to legacy WQP
ldecicco-USGS Nov 5, 2024
8ee4a7a
change example
ldecicco-USGS Nov 5, 2024
0b60de4
Another set of multi's
ldecicco-USGS Nov 5, 2024
6146ebb
wqp_check_status example
ldecicco-USGS Nov 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
push:
branches: [main]
branches: [main, develop]
pull_request:
branches: [main]
branches: [main, develop]

name: R-CMD-check

Expand Down
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ Copyright: This software is in the public domain because it contains materials
Depends:
R (>= 3.5.0)
Imports:
httr (>= 1.0.0),
curl,
lubridate (>= 1.5.0),
stats,
utils,
xml2,
readr (>= 1.4.0),
jsonlite
jsonlite,
httr2
Suggests:
covr,
dplyr,
Expand Down
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
dataRetrieval 2.7.18
===================
* Switched from httr to httr2
* Added a way to include a custom user-agent suffix via an enviornmental variable "CUSTOM_DR_UA"

dataRetrieval 2.7.17
Expand Down
Loading
Loading