Refactor string identifiers #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss_nhdplus_hr_waterbodies functions
…ip if python==3.11; inexplicable negative asum values that couldn't be reproduced locally
…o avoid confusion withfloats vs ints and issues with long identifiers such as those in NHDPlus HR that can't be represented as integers in 32-bit contexts
…n looking for a specified outlet
… avoid intermittent error that may be related to them getting modified
…o hopefully avoid intermittent failure that may be due to line along the edge of the grid not getting included in the SFR network for unknown reasons
…r unconnected reaches
…ient issue related to a library dependency); build docs in macos to avoid pyogrio.errors.DataSourceError when trying to open geodatabases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic preprocessing support for NHDPlus High Resolution data, and refactors SFRmaker to use strings for line (flowline) IDs internally. It also cleans up some tests that were failing for various reasons.