#2307 Multi-pass: copy feedback dir between passes (but remove nextpass.in) #3111
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpsijm
force-pushed
the
2307-multi-pass
branch
from
e54bb0b to
e99d5a0
Compare
meisterT
reviewed
Sep 28, 2025
judge/judgedaemon.main.php
Outdated
| mkdir($passdir, 0755, true); | ||
|
|
||
| if ($passCnt > 1) { | ||
| system('cp -R ' . $passdir . '/../' . ($passCnt - 1) . '/feedback ' . $passdir . '/'); |
There was a problem hiding this comment.
Good one! I've found dj_escapeshellargs in surrounding system() calls, so I've used that 🙂
judge/judgedaemon.main.php
Outdated
|
|
||
| if ($passCnt > 1) { | ||
| system('cp -R ' . $passdir . '/../' . ($passCnt - 1) . '/feedback ' . $passdir . '/'); | ||
| system('rm ' . $passdir . '/feedback/nextpass.in'); |
…e nextpass.in) This commit has been used in NWERC 2024 (d7cc716), as well as GCPC 2025 and BAPC 2025. It follows the latest release-candidate specification of multi-pass validation: https://www.kattis.com/problem-package-format/spec/2025-09.html#multi-pass-validation (the mirror at https://icpc.io/problem-package-format/spec/2025-09.html should be deployed "soon™"). Copying the feedback directory to the next pass is an implementation of "All other files inside the feedback directory are guaranteed to persist between passes." Additionally, "Note that the `nextpass.in` will be removed before the next pass." See also Kattis/problem-package-format#446 (comment)
mpsijm
force-pushed
the
2307-multi-pass
branch
from
e99d5a0 to
99db6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has been used in NWERC 2024 (d7cc716), as well as GCPC 2025 and BAPC 2025.
It follows the latest release-candidate specification of multi-pass validation: https://www.kattis.com/problem-package-format/spec/2025-09.html#multi-pass-validation (the mirror at https://icpc.io/problem-package-format/spec/2025-09.html should be deployed "soon™").
Copying the feedback directory to the next pass is an implementation of "All other files inside the feedback directory are guaranteed to persist between passes." Additionally, "Note that the
nextpass.inwill be removed before the next pass."See also Kattis/problem-package-format#446 (comment) and #2307.