Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded username, improve jq filtering #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove hardcoded username, improve jq filtering #10

wants to merge 1 commit into from

Conversation

cmbuckley
Copy link

What issue does this pull request resolve?

What changes did you make?

  • pages build was hardcoded to dp6 user; use .full_name to get user/repo format
  • use jq <<< $input rather than echo $input | jq
  • simplify repos filter to avoid multiple jq calls
  • while loop over repo full_name only to avoid b64 transcoding

Is there anything that requires more attention while reviewing?

@cmbuckley
fix: remove hardcoded username, improve jq filtering
d7781d2 
- pages build was hardcoded to dp6 user; use .full_name to get user/repo format
- use `jq <<< $input` rather than `echo $input | jq`
- simplify repos filter to avoid multiple jq calls
- while loop over repo full_name only to avoid b64 transcoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmbuckley