Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for tmux-2.6 #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix tests for tmux-2.6 #2

wants to merge 3 commits into from

Conversation

mjsir911
Copy link

This pull request just fixes some failing tests:

$ pytest
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /home/msirabella/Documents/projects/featurefork/neomutt/test/system/venv/bin/python3.6
cachedir: .pytest_cache
rootdir: /home/msirabella/Documents/projects/featurefork/neomutt/test/system/hecate, inifile: tox.ini
collecting ... collected 19 items

tests/test_hecate.py::test_can_launch_a_simple_program PASSED            [  5%]
tests/test_hecate.py::test_can_kill_vim PASSED                           [ 10%]
tests/test_hecate.py::test_can_write_unicode FAILED                      [ 15%]
tests/test_hecate.py::test_can_run_vim PASSED                            [ 21%]
tests/test_hecate.py::test_can_send_enter PASSED                         [ 26%]
tests/test_hecate.py::test_reports_abnormal_exit PASSED                  [ 31%]
tests/test_hecate.py::test_can_send_eof PASSED                           [ 36%]
tests/test_hecate.py::test_sets_the_console_size_appropriately PASSED    [ 42%]
tests/test_hecate.py::test_can_send_signals_to_child PASSED              [ 47%]
tests/test_hecate.py::test_uses_last_screenshot_if_server_goes_away FAILED [ 52%]
tests/test_mux.py::test_muxes_are_independent PASSED                     [ 57%]
tests/test_mux.py::test_has_no_buffers_to_start_with PASSED              [ 63%]
tests/test_mux.py::test_can_save_data_to_a_buffer PASSED                 [ 68%]
tests/test_mux.py::test_can_set_data_to_an_existing_buffer PASSED        [ 73%]
tests/test_mux.py::test_starts_with_a_single_session PASSED              [ 78%]
tests/test_mux.py::test_creates_sessions_of_desired_name PASSED          [ 84%]
tests/test_mux.py::test_can_capture_a_pane FAILED                        [ 89%]
tests/test_mux.py::test_can_send_content_to_the_screen PASSED            [ 94%]
tests/test_mux.py::test_can_detect_when_server_dies FAILED               [100%]

=================================== FAILURES ===================================
____________________________ test_can_write_unicode ____________________________
tests/test_hecate.py:34: in test_can_write_unicode
    h.await_text("☃")
../venv/lib/python3.6/site-packages/hecate/hecate.py:224: in await_text
    screen = self.screenshot()
../venv/lib/python3.6/site-packages/hecate/hecate.py:194: in screenshot
    result = self.tmux.capture_pane(0)
../venv/lib/python3.6/site-packages/hecate/tmux.py:124: in capture_pane
    buf = self.a_buffer()
../venv/lib/python3.6/site-packages/hecate/tmux.py:115: in a_buffer
    buffers = self.buffers()
../venv/lib/python3.6/site-packages/hecate/tmux.py:70: in buffers
    return _extract_names(self.execute_command("list-buffers"))
../venv/lib/python3.6/site-packages/hecate/tmux.py:46: in execute_command
    ).decode('ascii')
E   UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 22: ordinal not in range(128)

During handling of the above exception, another exception occurred:
tests/test_hecate.py:34: in test_can_write_unicode
    h.await_text("☃")
../venv/lib/python3.6/site-packages/hecate/hecate.py:278: in __exit__
    self.shutdown()
../venv/lib/python3.6/site-packages/hecate/hecate.py:164: in shutdown
    self.await_exit()
../venv/lib/python3.6/site-packages/hecate/hecate.py:246: in await_exit
    self.screenshot()
../venv/lib/python3.6/site-packages/hecate/hecate.py:194: in screenshot
    result = self.tmux.capture_pane(0)
../venv/lib/python3.6/site-packages/hecate/tmux.py:124: in capture_pane
    buf = self.a_buffer()
../venv/lib/python3.6/site-packages/hecate/tmux.py:115: in a_buffer
    buffers = self.buffers()
../venv/lib/python3.6/site-packages/hecate/tmux.py:70: in buffers
    return _extract_names(self.execute_command("list-buffers"))
../venv/lib/python3.6/site-packages/hecate/tmux.py:46: in execute_command
    ).decode('ascii')
E   UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 22: ordinal not in range(128)
________________ test_uses_last_screenshot_if_server_goes_away _________________
../venv/lib/python3.6/site-packages/hecate/tmux.py:45: in execute_command
    stderr=subprocess.STDOUT
/usr/lib64/python3.6/subprocess.py:336: in check_output
    **kwargs).stdout
/usr/lib64/python3.6/subprocess.py:418: in run
    output=stdout, stderr=stderr)
E   subprocess.CalledProcessError: Command '['tmux', '-u', '-L', 'e5fa548be551afd3', 'list-buffers']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:
tests/test_hecate.py:117: in test_uses_last_screenshot_if_server_goes_away
    assert "Hello" in h.screenshot()
../venv/lib/python3.6/site-packages/hecate/hecate.py:194: in screenshot
    result = self.tmux.capture_pane(0)
../venv/lib/python3.6/site-packages/hecate/tmux.py:124: in capture_pane
    buf = self.a_buffer()
../venv/lib/python3.6/site-packages/hecate/tmux.py:115: in a_buffer
    buffers = self.buffers()
../venv/lib/python3.6/site-packages/hecate/tmux.py:70: in buffers
    return _extract_names(self.execute_command("list-buffers"))
../venv/lib/python3.6/site-packages/hecate/tmux.py:50: in execute_command
    raise CommandFailed(e.output)
E   hecate.tmux.CommandFailed: b'no server running on /tmp/tmux-1000/e5fa548be551afd3\n'
----------------------------- Captured stdout call -----------------------------
Hello
























___________________________ test_can_capture_a_pane ____________________________
tests/test_mux.py:77: in test_can_capture_a_pane
    assert len(pane_contents.split("\n")) == 50
E   AssertionError: assert 51 == 50
E    +  where 51 = len(['hello world', '', '', '', '', '', ...])
E    +    where ['hello world', '', '', '', '', '', ...] = <built-in method split of str object at 0x7fe7e4a68420>('\n')
E    +      where <built-in method split of str object at 0x7fe7e4a68420> = 'hello world\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n'.split
_______________________ test_can_detect_when_server_dies _______________________
../venv/lib/python3.6/site-packages/hecate/tmux.py:45: in execute_command
    stderr=subprocess.STDOUT
/usr/lib64/python3.6/subprocess.py:336: in check_output
    **kwargs).stdout
/usr/lib64/python3.6/subprocess.py:418: in run
    output=stdout, stderr=stderr)
E   subprocess.CalledProcessError: Command '['tmux', '-u', '-L', b'aa4087f67a5543a6', 'list-sessions']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:
tests/test_mux.py:98: in test_can_detect_when_server_dies
    mux.sessions()
../venv/lib/python3.6/site-packages/hecate/tmux.py:94: in sessions
    return _extract_names(self.execute_command("list-sessions"))
../venv/lib/python3.6/site-packages/hecate/tmux.py:50: in execute_command
    raise CommandFailed(e.output)
E   hecate.tmux.CommandFailed: b'no server running on /tmp/tmux-1000/aa4087f67a5543a6\n'
===================== 4 failed, 15 passed in 4.74 seconds ======================

System info:

$ cat /proc/version 
Linux version 4.9.95-gentoo (root@Ridl3y) (gcc version 6.4.0 (Gentoo 6.4.0-r1 p1.3) ) #2 SMP Sun May 27 22:02:48 EDT 2018
$ tmux -V
tmux 2.6

Fair warning: may break tests for earlier versions of tmux, I couldn't test on those.

@mjsir911
Fix failing test_can_write_unicode
2dea2ce 
Opt for automatically detecting charset rather than manually specifying
@mjsir911
Fix 2 failing tests (both DeadServer related)
4238500 
Fixed `test_uses_last_screenshot_if_server_goes_away` and
`test_can_detect_when_server_dies`. This problem stemmed from
a different error message then expected, so just added that error
message.

Also added exception chaining to the exception handling, although this
is extra
@mjsir911
Fix failing test_can_capture_a_pane off by one error
092f811
asottile
asottile approved these changes Jul 27, 2019
View reviewed changes
Copy link

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for the patch

jayvdb
jayvdb approved these changes Dec 10, 2019
View reviewed changes
Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the errors I am seeing on all platforms, except s390x which still has an error in test_can_send_signals_to_child intermittently, and arm which havent started building yet.

@asottile
Copy link

@jayvdb if you're packaging this you probably want asottile@bbec887 as well

@mjsir911
Copy link
Author

Any idea about getting this merged @DRMacIver @jayvdb @asottile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvdb jayvdb jayvdb approved these changes

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjsir911 @asottile @jayvdb