Improve backlight related options for CP 20 phats #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the ds phat check to arm7, as on arm9 it was broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Separate backlight related logic by adding a new parameter
hasRegulableBacklightto systemdetails. With this now phats that have regulable backlights can benefit from the possibility to change it from the quick menu. If the quick menu is running on a phat, the "brightness" button will now behave like on stock firmware and just toggle the backlight on/off, on a phat with regulable backlight instead this will be the 5th "brightness" level.Changed the behaviour of the settings app of always turning on the backlight when exiting, now it will keep track of the original backlight state when it was launched.
Moved the ds phat detection code to arm7 as it was broken on arm9.
Where have you tested it?
Ds phat with cp 20 motherboard, ds lite, dsi from flashcard and dsi mode.
Pull Request status