incorrect success messages with tqdm progress bar tasks#108
Open
HolyMichael wants to merge 2 commits intoDS4SD:mainfrom
Open
incorrect success messages with tqdm progress bar tasks#108HolyMichael wants to merge 2 commits intoDS4SD:mainfrom
HolyMichael wants to merge 2 commits intoDS4SD:mainfrom
Conversation
Signed-off-by: Miguel Brandão <555migalves555@gmail.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Enforce conventional commitThis rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue arose from tqdm automatically saying success upon ending its task in conjunction with the inputs to a command resolving to an empty list of tasks.
for example to upload files, upon adding a non existing file the resulting "task_list" would be an empty list wich tqdm would grab, complete instantly and print out success
The solution applied to all (8) instances of this was to add a check for the list size, before dispatching tqdm, if the size was 0 print some error message and return out