Add index type checks and allowed file extensions#117
Open
SantanaTiago wants to merge 1 commit intoDS4SD:mainfrom
Open
Add index type checks and allowed file extensions#117SantanaTiago wants to merge 1 commit intoDS4SD:mainfrom
SantanaTiago wants to merge 1 commit intoDS4SD:mainfrom
Conversation
Signed-off-by: Tiago Santana <54704492+SantanaTiago@users.noreply.github.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Enforce conventional commitThis rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, toolkit does not take into account the type of the index, which may happen a user try to insert pdf documents into a
Genericindex or aJSONfile to aDocumenttype.This PR addresses this by checking the index type, and if the file format of the document matches the index type