raised some exceptions that were allowed to follow trough and some pr…#128
Open
HolyMichael wants to merge 3 commits intoDS4SD:mainfrom
Open
raised some exceptions that were allowed to follow trough and some pr…#128HolyMichael wants to merge 3 commits intoDS4SD:mainfrom
HolyMichael wants to merge 3 commits intoDS4SD:mainfrom
Conversation
…ints to typer.echo Signed-off-by: Miguel Brandão <555migalves555@gmail.com>
3dbd7db to
325d6ac
Compare
Signed-off-by: Miguel Brandão <555migalves555@gmail.com>
Signed-off-by: Miguel Brandão <555migalves555@gmail.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Enforce conventional commitThis rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3822
Need a sync on this one as I was unable to reproduce the exception pointed at in the issue