Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handling of single-cell tables in DOCX backend #314

Merged
merged 5 commits into from
Nov 12, 2024
Merged

fix: Handling of single-cell tables in DOCX backend #314

merged 5 commits into from
Nov 12, 2024

Conversation

maxmnemonic
Copy link
Contributor

Issue resolved by this Pull Request:
Resolves #291

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Handling of single-cell tables in DOCX backend
9569214 
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
@maxmnemonic maxmnemonic requested a review from cau-git November 12, 2024 08:47
@maxmnemonic maxmnemonic self-assigned this Nov 12, 2024
Maksym Lysak added 2 commits November 12, 2024 09:50
returned try-catch on tables handling
d8b4c07 
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
cleaned
f7b58df 
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
@maxmnemonic maxmnemonic mentioned this pull request Nov 12, 2024
Closed
@maxmnemonic maxmnemonic changed the title fix: Handling of single-cell tables in DOCX backend fix: (WIP) Handling of single-cell tables in DOCX backend Nov 12, 2024
Maksym Lysak added 2 commits November 12, 2024 14:26
proceed processing the content of single cell table as if its just pa…
b46ae1a 
…rt of the body

Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
Added example of trickly 1 cell table docx
31457ba 
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
@maxmnemonic maxmnemonic changed the title fix: (WIP) Handling of single-cell tables in DOCX backend fix: Handling of single-cell tables in DOCX backend Nov 12, 2024
@maxmnemonic maxmnemonic marked this pull request as ready for review November 12, 2024 13:50
cau-git
cau-git approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmnemonic maxmnemonic merged commit fb8ba86 into main Nov 12, 2024
7 checks passed
@maxmnemonic maxmnemonic deleted the dev/msword_1celltables branch November 12, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cau-git cau-git cau-git approved these changes

Assignees

@maxmnemonic maxmnemonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Text Inside Tables When Converting from DOCX to Markdown
2 participants
@maxmnemonic @cau-git