Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update and tests for right-to-left documents [probably needs to be closed, not merged] #883

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PeterStaar-IBM
Copy link
Contributor

Right to left support

  1. cleaned up the data folder in the tests
  2. added test documents for right-to-left

Checklist:

  • Documentation has been updated, if necessary.
  • Tests have been added, if necessary.

Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Copy link

mergify bot commented Feb 4, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@PeterStaar-IBM PeterStaar-IBM changed the title docs: add tests for right-to-left documents feat: add update and tests for right-to-left documents Feb 4, 2025
PeterStaar-IBM and others added 2 commits February 4, 2025 14:49
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
@dolfim-ibm
Copy link
Contributor

Superseded by #903.

@dolfim-ibm dolfim-ibm closed this Feb 6, 2025
@cau-git cau-git reopened this Feb 6, 2025
@PeterStaar-IBM PeterStaar-IBM changed the title feat: add update and tests for right-to-left documents feat: add update and tests for right-to-left documents [probably needs to be closed, not merged] Feb 7, 2025
@cau-git
Copy link
Contributor

cau-git commented Feb 7, 2025

Note: We keep this open as draft to preserve this commit only: 7bdd686
It will be picked up in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants