Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touching up Redirects to New Site #761

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Touching up Redirects to New Site #761

merged 1 commit into from
Oct 30, 2024

Conversation

lhr-git
Copy link
Contributor

@lhr-git lhr-git commented Oct 30, 2024

Description

these changes let the checklist url redirect without a hard /, and don't forward the querystring with the redirect for the checklist.

List of proposed changes:

  • Changes to checklist redirects

What to test for/How to test

Changes are live on dev.

Additional Notes

They can go live when ready. No need to plan a release.

@lhr-git lhr-git requested a review from a team as a code owner October 30, 2024 16:00
Copy link
Contributor

@sebastien-comeau sebastien-comeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ? required at the end of https://www.canada.ca/en/services/retirement/quiz-main.html??

@lhr-git
Copy link
Contributor Author

lhr-git commented Oct 30, 2024

Is ? required at the end of https://www.canada.ca/en/services/retirement/quiz-main.html??

Yes, it removes the query strings from the tail end.

@lhr-git lhr-git merged commit 2119d8c into main Oct 30, 2024
4 checks passed
@lhr-git lhr-git deleted the lhr-redirects-continued branch October 30, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants