Analyzer to extract PDS raw waveforms #117
Conversation
…nvolution of streaming channels, where the waveforms are too long and the optimization takes too much time (minutes). For future, we may consider making an option to switch the optimization on/off, if it benefits the performance for the self-triggering channels.
…TTree. This is similar to what the decoder (duneprototypes/Protodune/hd/RawDecoding/DAPHNEReaderPDHD_module.cc) does, but there not all the branches are populated.
…D VD raw data (hdf5).
lpaulucc
left a comment
lpaulucc
left a comment
There was a problem hiding this comment.
Hi Viktor, I am starting to find the Optical Detector folder a bit crowded. What would you think about moving this module to duneopdet/OpticalDetector/Ana?
| } | ||
|
|
||
| produce: [ rns,triggerrawdecoder,pdvddaphne ] | ||
| analyze: [ rawwfmana ] |
There was a problem hiding this comment.
I assume this analyzer can be run over the already centrally processed PDVD keep up data, right? Maybe create this fhicl as a ana job only and include in the header over what kind of output to run it?
There was a problem hiding this comment.
I am not sure what you are asking for. Sure, this fhicl can be rewritten to be used on keep up data. However, I don't know how to make it universal. For the PDS system, this format is useful as not all PDS runs were processed in the keep up, or am I wrong here?
There was a problem hiding this comment.
Ok, it is fine to leave it as it is, with producers. It is not hard to adapt to whatever you need. Thanks, Viktor
|
Moving this to subdir ana sounds good to me. |
…e build. Adding Ana/CMakeLists.txt that allows build ing the code. Code not meant for being built is currently excluded explicitly.
|
I have moved the module to the Ana subdir. I have tested it compiled and installed. Does this look OK, @lpaulucc? |
|
I have also created a prolog file to place standard configurations for the analyzer in there. Currently only configurations for PDHD/VD data is there. I plan to add sim versions too, though I am not sure if sims would have a |
lpaulucc
left a comment
lpaulucc
left a comment
There was a problem hiding this comment.
Nice, Viktor. I hope this does not clash with my latest PR that already included a CMakeLists to this folder.
|
I tested this with the head of develop. All seemed to have built OK. I removed one line which your updates to the structure of Ana made obsolete. |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build DUNE phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
This adds an analyzer module which extracts PDS raw waveforms and stores them into a simplified ROOT TTree, 1 waveform per tree entry.
I also added a fhicl file to run the DAPHNE decoder and the analyzer at one go for PDVD. This is to be used on PDVD raw data stored in hdf5 files. The output is only the ROOT file with the simplified TTree, the name of which can be specified on the command line with the option
-T.