Update VD Xe10ppm digitizer settings #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make standard_vddaphne_xe10ppm inherit from standard_vddaphne
vpec0
approved these changes
Dec 17, 2025
Member
vpec0
left a comment
vpec0
left a comment
There was a problem hiding this comment.
Looks like simple enough change.
Does anyone still use the WaveformDigitizer module?
Member
Author
|
Yes, this module is in the default sim chain for FD-VD. This breaks the simulation with Xe doping into two modules, one that handles the differences between Xe and Ar (SiPMSim) and another one (this one) that handles the digitizer, which does not care about Xe/Ar differences. It makes the code cleaner and easier to understand in my opinion than having a very long code that handles it all together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make standard_vddaphne_xe10ppm inherit from standard_vddaphne