Skip to content

Conversation

@nvpm-lab
Copy link
Member

@nvpm-lab nvpm-lab commented Dec 8, 2025

The SimChannelSink and DepoSetSimChannelSink are obsolete. We transition their configuration to that of DepoFluxWriter.

@nvpm-lab nvpm-lab assigned nvpm-lab and unassigned nvpm-lab Dec 9, 2025
@HaiwangYu
Copy link
Contributor

Hi @nvpm-lab Thanks a lot for taking care of this and doing the validation work!
Using your ROOT file, it seems the time offsets are correct.
I am OK with this PR.

Screenshot 2025-12-09 at 21 19 08

@nvpm-lab
Copy link
Member Author

@wyjang-uta could you have a look

@YoannKermaidic
Copy link
Member

Hi,
I see it affects PDSP, PDHD and PDVD.
@calcuttj are you also fine with this update?

I wonder whether it changes anything for the simulation pipeline in terms of written products/fields?

@calcuttj
Copy link
Collaborator

I think this should be fine on the MC truth side

@tomjunk
Copy link
Member

tomjunk commented Dec 23, 2025

trigger build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants