Feature/nived supera #170
Feature/nived supera #170
Conversation
…tool has been vetted and is actively used by both SBN experiments. Ultimately it belongs in larreco but that PR appears to be stalled and so adding here temporarily to facilite MC production for upcoming SPINE workshop.
|
@nvpm-lab We need to update ups_products to the correct/up-to-date version before this can be merged |
…I needed to add "duneprototypes" to top level CMakeLists.txt file but not "larcv2")
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
There is mention of sbnsoftware/sbncode in the cmake shim that makes sure mrb can gitcheckout the submodule. The comment is harmless, and the shim looks general enough that spack probably won't gag on it. |
|
✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
|
PDVD tests failed but they have a maintenance issue. Also this, PR introduces a dependency of dunereco on duneprototypes, but fortunately this does not create a loop in the dependency graph, as duneprototypes currently does not depend on dunereco. |
|
It does look like the particular commit of Supera is limited to ProtoDUNE-VD CRT hits: |
Add Supera as a submodule and larcv2 as a dependency, essential for SPINE pipeline.