-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Spectrum to 1.20 #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a 1.20.1 branch 👌 |
Any updates on this? The last commit was 2 weeks ago |
This branch/PR is still being worked on. I will note that release-wise this will release at a later time than the DD update, so that there is time to test things. Its only a bit behind upstream at the moment |
…er-down # Conflicts: # src/main/java/de/dafuqs/spectrum/registries/SpectrumBlocks.java
# Conflicts: # gradle.properties # src/main/java/de/dafuqs/spectrum/SpectrumCommon.java # src/main/java/de/dafuqs/spectrum/blocks/chests/HeartboundChestBlock.java # src/main/java/de/dafuqs/spectrum/blocks/farming/TilledSlushBlock.java # src/main/java/de/dafuqs/spectrum/blocks/pastel_network/network/PastelTransmissionLogic.java # src/main/java/de/dafuqs/spectrum/blocks/potion_workshop/PotionWorkshopBlockEntity.java # src/main/java/de/dafuqs/spectrum/blocks/redstone/BlockDetectorBlock.java # src/main/java/de/dafuqs/spectrum/entity/entity/KindlingEntity.java # src/main/java/de/dafuqs/spectrum/entity/render/KindlingEntityRenderer.java # src/main/java/de/dafuqs/spectrum/helpers/InWorldInteractionHelper.java # src/main/java/de/dafuqs/spectrum/items/GuidebookItem.java # src/main/java/de/dafuqs/spectrum/registries/SpectrumBlocks.java
Some game event and world event emitters were added with this. I believe game events trigger things like vibration listeners. Unsure about the world event emitters though, although the game event for a dispenser failing was removed. Because of this I replaced it with a block activate event
…taff still can't)
Signed-off-by: Noaaan <noaaan@hotmail.com>
Merging this, before github gives up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spectrum 1.20
Will re-target towards a 1.20 branch once I can find the time.
Reason for a PR over directly pushing onto a separate branch is to note down what exactly changed between 1.19 and 1.20.
Non-exhaustive list of version changes
world
is now private in tons of places, like entities, meaning you need to usegetWorld()
insteadminecraft:alternative
loot condition is now namedminecraft:any_of
. A newminecraft:all_of
also exists nowCurrent problems
Advancements are broken. Mainly due to malformedNow fixed ✅location
predicates.Patchouli does not work due to everything being placed under data.fixed by Daf ✅Colorful Hearts (formerly Health Overlay) does not use a DrawContext, meaning we have to make one ourselves for our compatNow fixed ✅Now fixed ✅InkProjectileKillingCriterion
is not implemented correctlyChest Textures do not work, as they are not placed in any atlas at the moment. Only thing holding back updating this is verifying that the chests were properly renamedNow fixed by moving into block atlas ✅ Needs verification as some chest names in lang and classes seem to be un-renamed.Now fixed thanks to Electro ✅SpectrumRegistries
should be ported to the new format which does not take in an Entity class, as it is deprecated.GatedSpectrumEmiRecipe
should be changed to respect the DynamicRegistryManager. It needs to grab this from some world, or pass an empty DRM (not ideal)~~Fixed by Electro ✅