-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom settings feature #13
base: master
Are you sure you want to change the base?
Add custom settings feature #13
Conversation
While an easier setup would be nice to have there are a few notes:
I will look into reading the grid size from the JSON file, but as i said above i'll probably rewrite the setup process sooner or later. That will result in the PowerShell script getting obsolete. |
Ideally, yes. As long as it stays a manually triggered process, especially for files outside the mod folder.
I agree that it is the better resolution. But it shouldn't be the default, because most people probably still have 1080p monitors and 1024 won't fit on the screen.
The grid size determines how the camera is moving, correct? So if a screen capture is taken at |
1024x1024 including the border and title bar does fit on a full HD screen, as long as the window is moved to the topmost position. It doesn't matter if some part is covered by the taskbar.
Exactly, but it seems that Noita distributes entity generation for a chunk over several frames. There is only a way to check if a chunk is loaded, i already do that and wait until all chunks are there and get rendered. But it can still happen that Noita takes its time to fill the chunk with entities and scenery. And if the grid size is smaller, the game has more time to load stuff in neighbor chunks (which may be already loaded outside of the viewport). A grid size of 512 is a good tradeoff for speed and correctness.
Well, 512 creates 4 times as much pixels (Due to overlap), but the chunks that are already generated will not slow down the capturing process much, and the speed mainly depends on how fast Noita can generate chunks. From my experience it's about twice as fast, maybe 2.5 times. Anyways, i'm currently rewriting some logic (E.g. how coordinate systems are transformed) that would allow the mod to work with any window resolution and still be as pixel perfect as possible. After that i'll look into adding a user interface so everything can be set up inside Noita itself. Ideally, if everything works as expected, you just have to start the game with the mod enabled, change some stuff (maybe restart Noita) and start capturing. Additionally it should work well with the normal and dev version of the game, so you can also use the mod to capture progress while playing. |
@Dadido3 this is the pull request for the settings feature. It just needs one more thing to properly work, which is that in capture.lua the
CAPTURE_GRID_SIZE
should be read fromsettings.jsonc
if the file exists, otherwise read it fromsettings.default.jsonc
.