Centralized Media Management #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This folder is gonna be bloated and I'd rather not go insane.
|
I can't believe they killed disco inferno |
It can now be toggled for a quick test, and is actually valid.
All but the default json is gitignored for media, Makes testing easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Refactors configurable media track management into a centralized, shared system.
Also kills the disco jukebox, that thing's a dumpster fire.
Why It's Good For The Game
Centralized management allows for tracks to be parsed exactly once, instead of repeatedly for the various purposes, as well as allowing sounds to be cleanly shared between pools, such as allowing various title tracks to be played in the IC jukeboxes.
Changelog
🆑
config: Credits music, Lobby tracks, and Jukebox media organization has changed massively. Check the repo for more information.
del: Disco Inferno has been made far less disco.
/:cl: