POC: tick bar for charge based spells #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports subsequent commits where additional tick bars are supported by BCM. This makes these helper fuctions re-usable outside of solely SecondaryPowerBar tick bars.
This introduces a POC for creating a tickbar for charge based spells. This is helpful for users who wish to visualize these spells in a smaller formfactor than icons (which is already supported in custom and additional custom).
Very rough POC of supporting configuring the tick bar in the settings GUI. Most of this code is adapted from existing functions and needs to be improved.
This introduces functionality to re-init the custom tickbar for relevant events e.g. specialization change, settings changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Overview
First off thank you for your work on this addon, I've found it great to use. I brought up the possibility of a tick bar implementation for custom charge based spells in the Discord the other day and put together this very rough proof of concept. Please keep this in mind when reviewing the code in its current state..
What I'm hoping to gather at this point is the interest level of the maintainer(s) before spending more time to clean this up for production PR with additional features.
Feature Goals
POC
I've included an image and .mkv (video file) of the POC to illustrate.
output.mp4
If there interest in moving this forward I'm happy to continue sprucing this up and addressing any feedback or guidance you have on the feature/code changes.
Thanks!