Feature: Out-of-Combat Fade with Target-Override #201
+219
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of Combat Fade Enhancements
Heyhey thank you for your great project! 👌🏼👌🏼This is truly a valid replacement for SUF!
For me there was just one feature missing: out-of-combat fade with target-filtering.
I added these options to all frames, including the boss frame as the current concept is to keep everything in every frame.
No errors in BugSack so far.
Global & Per-Frame Fade Settings
You can configure a single global fade opacity or override it per unit frame (player, target, focus, pet, boss, etc.).
Target-Based Fade Override
New option to disable fading when a target is selected, with a reaction filter
Event Handling & GUI
Automatic updates on combat state changes, new GUI controls in the General tab, clear info tooltips.
Future improvements may
Filtering Fade-Override for Hostile/Friendly/Both
Formatting
Changed files where linted and formated by Lua linter. Thats why there are some structural changes included.Had to turn off auto-formatter. Some functions are very uncomfortable to read. Defaults.lua has missing whitespaces after/in brackets. Maybe consider these changes :)