[kayden] Week 01 Solutions #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kjb512
commented
Aug 16, 2024
•
kjb512
commented
- Contains Duplicate #217
- Number of 1 Bits #232
- Top K Frequent Elements #237
- Kth Smallest Element In a Bst #252
- Palindromic Substrings #267
|
고생하셨습니다. 이번주 모임에서 의논할 사안인것 같지만 현재 파일내용을 보시면 각 파일 맨 아래 라인브레이크가 설정되지 않아 빨간색 마크가 표시되어 있을거예요. 해당내용 수정해주시면 감사하겠습니다! |
leokim0922
reviewed
Aug 17, 2024
number-of-1-bits/kayden.py
Outdated
There was a problem hiding this comment.
쉽고 간결한 풀이네요 👍 다만 해당 문제의 목적 자체는 이진연산을 활용하는 것이기에, 시간이 나신다면 다른 방법으로도 풀어서 시간복잡도를 줄여보는것도 좋을것같습니다!
There was a problem hiding this comment.
리뷰 해주셔서 감사합니다! 이진연산으로 풀어볼 생각은 못해봤네요! 내일 모임 전에 한번 시도해보겠습니다!
leokim0922
reviewed
Aug 17, 2024
contains-duplicate/kayden.py
Outdated
| class Solution: | ||
| def containsDuplicate(self, nums: List[int]) -> bool: | ||
| unique_nums = set(nums) | ||
| return len(unique_nums) != len(nums) |
There was a problem hiding this comment.
간결함을 원하신다면 unique_nums를 그냥 return 다음으로 옮겨버리는거도 나쁘지 않아보이네요 :)
return len(set(nums)) != len(nums)
DaleSeo
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.