Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request 템플릿 추가 #381

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Pull Request 템플릿 추가 #381

merged 1 commit into from
Aug 26, 2024

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Aug 25, 2024

프로젝트 연결과 코드 검토자 지정을 기억하시는데 도움이 되지 않을까하여 PR 템플릿을 만들어 보았습니다 :)

Comment on lines +12 to +17
## 체크 리스트

- [ ] PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
- [ ] 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
- [ ] 문제를 모두 푸시면 프로젝트에서 Status를 `In Review`로 설정해주세요.
- [ ] 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 것 같습니다

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bky373 bky373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

Copy link
Contributor

@wogha95 wogha95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~! 👏

@DaleSeo DaleSeo merged commit daa942f into DaleStudy:main Aug 26, 2024
1 check passed
@highballplz
Copy link
Contributor

감사합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants