Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[윤태권] Week6 문제 풀이 #469

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

taekwon-dev
Copy link
Contributor

@taekwon-dev taekwon-dev commented Sep 18, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@taekwon-dev taekwon-dev requested a review from HC-kang September 18, 2024 09:01
@taekwon-dev taekwon-dev marked this pull request as ready for review September 21, 2024 05:35
@taekwon-dev taekwon-dev requested a review from a team as a code owner September 21, 2024 05:35
Copy link
Contributor

@HC-kang HC-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taekwon-dev 님 이번 한 주도 고생 많으셨습니다!

}

char c = word.charAt(index);
if (c != '.') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중요하지 않은 부분이니 무시하셔도 좋습니다!
어차피 if ~ else ~ 로 양분되는 조건이라면 c != '.' 대신 c == '.' 형태로 긍정 조건문을 사용하면 가독성 면에서 좀 더 읽기 쉽지 않을까 싶었습니다!

continue;
}

if (stack.isEmpty() || stack.removeFirst() != map.get(c)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 Java를 잘 모르는데, stack에서 removeFirst()가 pop()의 역할을 하는걸까요?? 얼핏 드는 생각으로는 정 반대로 맨 앞의 원소를 반환할 것 같아서요

@SamTheKorean SamTheKorean merged commit cd07110 into DaleStudy:main Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants