Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[정현준] 12주차 #566

Merged
merged 5 commits into from
Nov 3, 2024
Merged

[정현준] 12주차 #566

merged 5 commits into from
Nov 3, 2024

Conversation

jdalma
Copy link
Member

@jdalma jdalma commented Oct 28, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jdalma jdalma requested a review from obzva October 28, 2024 06:15
@jdalma jdalma self-assigned this Oct 28, 2024
} else if (p == null || q == null || p.`val` != q.`val`) {
false
} else {
isSameTree(p.left, q.left) && isSameTree(p.right, q.right)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin은 Implicit return이 가능하군요 ㅎㅎ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코틀린에서는 if문과 try문을 식으로 작성할 수 있더라구요 ㅎㅎ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 return 문이었네요 이거 ㅋㅋㅋ 제가 잘못 봤습니다
이것도 또한 특이하네요

return result;
}

private int union(int[] relation, int[] edge) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

union find 풀이 잘 보았습니다 :)
helper 함수 깔끔하게 잘 나누어져 있어서 보기에도 편했습니다

@jdalma jdalma marked this pull request as ready for review November 1, 2024 04:51
@jdalma jdalma requested a review from a team as a code owner November 1, 2024 04:51
@jdalma jdalma merged commit 1ffbcc7 into DaleStudy:main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants