Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmlwls96] Week1 #662

Merged
merged 9 commits into from
Dec 15, 2024
Merged

[gmlwls96] Week1 #662

merged 9 commits into from
Dec 15, 2024

Conversation

gmlwls96
Copy link
Contributor

@gmlwls96 gmlwls96 commented Dec 9, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@gmlwls96 gmlwls96 requested a review from Totschka December 9, 2024 14:24
@gmlwls96 gmlwls96 requested a review from a team as a code owner December 9, 2024 14:24
@github-actions github-actions bot added the kotlin label Dec 9, 2024
@obzva
Copy link
Contributor

obzva commented Dec 11, 2024

풀이하느라 수고하셨습니다 ㅎㅎㅎ
피드백 드리자면,

  1. Big O 분석을 남겨주시면 더 좋을 것 같습니다
  2. Kotlin의 구문 및 문법에 익숙하지 않은 리뷰어가 읽기엔 가독성이 떨어집니다, 다른 분들이 리뷰를 수월하게 할 수 있게 주석을 작성해주시면 더 좋을 것 같아요

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 문제의 답안 코드에 문제가 있는 것 같습니다. 오늘이 마감이라서 우선 승인드릴테니 문제 해결하신 후에 병합 부탁드리겠습니다.

house-robber/gmlwls96.kt Outdated Show resolved Hide resolved
@gmlwls96 gmlwls96 merged commit d0d1fb8 into DaleStudy:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants