Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zioq] Week 1 #675

Merged
merged 9 commits into from
Dec 14, 2024
Merged

[Zioq] Week 1 #675

merged 9 commits into from
Dec 14, 2024

Conversation

Zioq
Copy link
Contributor

@Zioq Zioq commented Dec 11, 2024

답안 제출 문제

  • Contains Duplicate
  • Valid Palindrome
  • Top K Frequent Elements
  • Longest Consecutive Sequence
  • House Robber

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@Zioq Zioq requested a review from a team as a code owner December 11, 2024 00:06
@github-actions github-actions bot added the js label Dec 11, 2024
@Zioq Zioq requested a review from Real-Reason December 11, 2024 00:08
@Zioq Zioq changed the title Week 1 [Zioq 한재현]Week 1 Dec 11, 2024
@Zioq Zioq changed the title [Zioq 한재현]Week 1 [Zioq] Week 1 Dec 11, 2024
@Zioq Zioq removed the js label Dec 11, 2024
Comment on lines 11 to 14
if(dup_set.size !== nums.length) {
return true
}
return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return 자체를 비교문으로 하면 어떨까요?
return dup_set.size !== nums.length 같이요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 하는 방법도 있었군요 :) 좀 더 코드가 심플해지겠어요 감사합니다 ;)

@TonyKim9401
Copy link
Contributor

첫주 문제 풀이 하시느라 고생 많으셔요 :)
주석으로 시간, 공간 복잡도 계산 및 접근 방법도 포함되면 코드 이해하는데 더 도움이 될 것 같습니다!

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다!
linlint 체크가 실패하고 있어서 승인을 받으셔도 PR 병합이 불가능하실 거에요.
아래의 공지를 참고하셔서 조치 부탁드립니다.
#664 (comment)

@Zioq Zioq merged commit 5acf128 into DaleStudy:main Dec 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants