Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[khyo] Week 1 #676

Merged
merged 5 commits into from
Dec 15, 2024
Merged

[khyo] Week 1 #676

merged 5 commits into from
Dec 15, 2024

Conversation

HiGeuni
Copy link
Contributor

@HiGeuni HiGeuni commented Dec 11, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@HiGeuni HiGeuni requested a review from Zioq December 11, 2024 02:53
@HiGeuni HiGeuni requested a review from a team as a code owner December 11, 2024 02:53
@github-actions github-actions bot added the js label Dec 11, 2024
@HiGeuni HiGeuni added the js label Dec 11, 2024
Copy link
Contributor

@obzva obzva Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 파일을 다른 폴더에 생성하신 것 같아요
longest-consecutive-sequence 폴더 아래에 생성해주세요~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 반영했습니다.


var topKFrequent = function(nums, k) {
const countObject = {}
nums.map((num) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

결과는 비슷할 것 같은데 .map 메소드 대신에 .forEach메소드를 사용하시는게 더 적절하지 않을까 싶어요 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

덕분에 차이를 공부해보면서 .map.forEach의 반환값 차이가 있다는 것을 알게되었습니다 😊

감사합니다!!

Copy link
Contributor

@obzva obzva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

풀이가 깔끔하고 좋네요 ㅎㅎ 수고하셨습니다

Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 깔끔한 풀이 잘 보았습니다 ㅎㅎ 고생많으셨습니다!

@HiGeuni HiGeuni merged commit dcb6bb6 into DaleStudy:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants