[JonghunLee] Week 1 #698
Merged
[JonghunLee] Week 1 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
공지사항 filename 에러 저의 경우 파일명을 아래 분들도 저와 유사한 이슈 같아 보입니다! |
HC-kang
approved these changes
Dec 14, 2024
|
|
||
| return True | ||
|
|
||
| def check_palindrome(self, i, end, joined_string) -> bool: |
There was a problem hiding this comment.
중요하지 않은 사항입니다. 무시하셔도 좋습니다!
특별한 이유가 없으시다면 i, j 혹은 start, end 등으로 스타일을 맞춰주시는 편이 좀 더 보기 좋고, 나중에 혹시라도 면접관으로부터 공격(?)의 여지를 덜 주지 않을까 싶어서 의견 드립니다!
There was a problem hiding this comment.
리뷰해주셔서 감사합니다!
넵 알겠습니다ㅎㅎ 코드를 보고 명확 네이밍을 사용하도록 하겠습니다. 중요한 부분 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
답안 제출 문제
체크 리스트
In Review로 설정해주세요.