Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[donghyeon95] Week 1 #701

Merged
merged 7 commits into from
Dec 14, 2024
Merged

[donghyeon95] Week 1 #701

merged 7 commits into from
Dec 14, 2024

Conversation

donghyeon95
Copy link
Contributor

@donghyeon95 donghyeon95 commented Dec 14, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@donghyeon95 donghyeon95 self-assigned this Dec 14, 2024
@donghyeon95 donghyeon95 requested a review from a team as a code owner December 14, 2024 07:35
@donghyeon95 donghyeon95 requested review from o-ddong and removed request for imsosleepy December 14, 2024 07:44
@donghyeon95 donghyeon95 changed the title [donghyeon] Week 1 [donghyeon95] Week 1 Dec 14, 2024
Copy link
Contributor

@o-ddong o-ddong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 고민 많이 하시면서 문제 잘 해결하신 것 같습니다!
제 수준에서는 커멘트 드릴 내용이 없어보여요ㅎㅎ.. 푸신 내용 잘봤습니다 고생하셨습니다 :)

Comment on lines +31 to +34
result = Math.max(recurse(nums, index+2)+nums[index], result);

// 나를 선택하지 않는 경우,
result = Math.max(recurse(nums, index+1), result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재귀로 푸신 방법도 너무 좋아보이네요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반갑습니다 동훈님.
재귀 말고 반복문으로 푸는 게 성능 상 이점이 있을 거 같은데
시간이 없어서 못 해본 게 아쉽습니다.

리뷰 감사드리고, 3기 화이팅입니다.

@donghyeon95 donghyeon95 merged commit 602ff70 into DaleStudy:main Dec 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants