[mallayon] Week 2 #717
Merged
[mallayon] Week 2 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmyeon 님 안녕하세요! TypeScript는 처음이라 생소했는데, 주석을 자세하게 달아주셔서 코드를 이해하기 쉬웠습니다 :) indentation도 깔끔하게 해주셔서, 리뷰하면서 많이 배울 것 같습니다! |
KwonNayeon
approved these changes
Dec 21, 2024
Comment on lines
+17
to
+30
| function climbStairs(n: number): number { | ||
| if (n <= 2) return n; | ||
|
|
||
| let prevPrevSteps = 1; | ||
| let prevSteps = 2; | ||
|
|
||
| for (let i = 3; i <= n; i++) { | ||
| const currentSteps = prevPrevSteps + prevSteps; | ||
| prevPrevSteps = prevSteps; | ||
| prevSteps = currentSteps; | ||
| } | ||
|
|
||
| return prevSteps; | ||
| } |
There was a problem hiding this comment.
TypeScript는 잘 몰라서 제 파이썬 코드와 비교해봤는데, @mmyeon 님 코드를 통해서 중간 결과를 dp 배열에 모두 저장하는 대신 두 개의 변수만 사용하면 공간복잡도를 더 최적화할 수 있다는 걸 배웠어요!
There was a problem hiding this comment.
@KwonNayeon
안녕하세요! 귀중한 시간 내어서 코드 리뷰 해주셔서 정말 감사합니다 👍
저도 다른 분들 풀이 참고해서 작성해보았는데 도움이 되셨다니 뿌듯합니다.
다시 한번 감사드립니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.