Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ganu] Week 2 #734

Merged
merged 6 commits into from
Dec 22, 2024
Merged

[ganu] Week 2 #734

merged 6 commits into from
Dec 22, 2024

Conversation

gwbaik9717
Copy link
Contributor

@gwbaik9717 gwbaik9717 commented Dec 17, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@gwbaik9717 gwbaik9717 requested a review from Jay-Mo-99 December 17, 2024 23:57
@gwbaik9717 gwbaik9717 self-assigned this Dec 17, 2024
@gwbaik9717 gwbaik9717 requested a review from a team as a code owner December 17, 2024 23:57
@github-actions github-actions bot added the js label Dec 17, 2024
@HC-kang
Copy link
Contributor

HC-kang commented Dec 18, 2024

안녕하세요~ @gwbaik9717 님!
PR 템플릿의 프로젝트의 주차 설정 체크는 되어있는데, 실제 설정이 누락되어있네요. 확인 부탁드려요!

Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다섯 문제 모두 푸시느라 고생많으셨습니다! 전반적으로 코드가 가독성이 좋아서 논리를 따라가기 쉬웠습니다!

@SamTheKorean SamTheKorean merged commit 8e95fdc into DaleStudy:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants