[anniemon78] Week 2 #748
Merged
[anniemon78] Week 2 #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgonD3V
approved these changes
Dec 21, 2024
3sum/anniemon.js
Outdated
Comment on lines
20
to
21
| } | ||
| let l = i + 1; |
There was a problem hiding this comment.
코드 가독성을 위해서 논리적으로 구분되는 부분들을 띄워주시면 좋을 것 같습니다
climbing-stairs/anniemon.js
Outdated
| * @return {number} | ||
| */ | ||
| var climbStairs = function(n) { | ||
| const memo = { 1:1, 2:2 }; |
There was a problem hiding this comment.
만약 제가 면접관이라면 왜 list가 아닌 map을 사용했는지 물어볼 것 같습니다. 개인적으로 이전 단계의 값으로 다음 단계의 값을 구한다는 의미에는 list가 더 적합하지 않을까 싶습니다.
There was a problem hiding this comment.
좋은 포인트네요. 반영했습니다.
감사합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.