Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[donghyeon95] Week3 #803

Merged
merged 5 commits into from
Dec 28, 2024
Merged

[donghyeon95] Week3 #803

merged 5 commits into from
Dec 28, 2024

Conversation

donghyeon95
Copy link
Contributor

@donghyeon95 donghyeon95 commented Dec 28, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@donghyeon95 donghyeon95 requested a review from a team as a code owner December 28, 2024 09:29
@github-actions github-actions bot added the java label Dec 28, 2024
@donghyeon95 donghyeon95 requested a review from HiGeuni December 28, 2024 09:29
Copy link
Contributor

@HiGeuni HiGeuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번주도 고생많으셨습니다!!
자바는 잘 몰라서 자세하게 코멘트는 못하지만, 제가 푼 문제들은 비슷한 로직으로 푼 거 같네 요 ㅎㅎ
product of array except self는 더 효율적으로 푸신거 같아요!!

@donghyeon95
Copy link
Contributor Author

@HiGeuni 리뷰 감사드립니다. "v"
저는 combination sum에서 중복 제거하는 로직이 조금 맘에 안들어서
어떻게 해야 할 지 고민이긴 합니다 ㅎㅎ

요번주도 고생 많으셨고, 다음주도 화이팅입니다!!!

@donghyeon95 donghyeon95 merged commit f3bd1a4 into DaleStudy:main Dec 28, 2024
3 checks passed
@donghyeon95 donghyeon95 requested a review from HodaeSsi December 28, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants