Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mintheon] Week 4 #813

Merged
merged 4 commits into from
Jan 4, 2025
Merged

[mintheon] Week 4 #813

merged 4 commits into from
Jan 4, 2025

Conversation

mintheon
Copy link
Member

@mintheon mintheon commented Dec 29, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@mintheon mintheon requested a review from Jeehay28 December 29, 2024 13:27
@mintheon mintheon self-assigned this Dec 29, 2024
@mintheon mintheon requested a review from a team as a code owner December 29, 2024 13:27
@github-actions github-actions bot added the java label Dec 29, 2024
Copy link
Contributor

@obzva obzva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@@ -0,0 +1,33 @@
class Solution {
/**
시간복잡도: O(n^2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실상 삼중 for statement인데, O(n^3)으로 볼 수도 있을까요? 의견 궁금합니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실상 삼중 for statement인데, O(n^3)으로 볼 수도 있을까요? 의견 궁금합니다

for 루프가 3개라고 해서 무조건 n^3는 아니지만, 해당 코드는 말씀하신대로 n^3의 경우로 보이네요!
결국 while내 호출이 될때마다 최대 O(n) 만큼의 작업이 추가 수행되는 부분을 놓쳤네요.

return false;
}

private boolean hasWord(int y, int x, String word, int index) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String word도 함수의 argument로 넘기는 대신 class 변수로 등록해놓고 사용할 수 있을까요?

@obzva
Copy link
Contributor

obzva commented Jan 4, 2025

@Jeehay28 담당 PR 리뷰도 진행해주시길 바랍니다
참여자 역할 참고

@mintheon mintheon merged commit 85b82a7 into DaleStudy:main Jan 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants