Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HerrineKim] Week 7 #950

Merged
merged 2 commits into from
Jan 25, 2025
Merged

[HerrineKim] Week 7 #950

merged 2 commits into from
Jan 25, 2025

Conversation

HerrineKim
Copy link
Contributor

@HerrineKim HerrineKim commented Jan 25, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@HerrineKim HerrineKim requested a review from a team as a code owner January 25, 2025 07:17
@github-actions github-actions bot added the js label Jan 25, 2025
@HerrineKim HerrineKim requested a review from mike2ox January 25, 2025 07:18
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! set matrix zeroes 문제 같은 경우 공간복잡도 최적화가 더 가능해 보이는데 주석으로 남기시거나 답안을 하나 더 작성하는 것도 추천합니다! 연휴 잘보내세요!

Comment on lines +14 to +15
const zeroRows = new Array(rows).fill(false);
const zeroCols = new Array(cols).fill(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공간 복잡도를 약간(?) 포기하는 대신에 가독성을 늘리는 쪽을 개인적으로는 이쪽을 더 선호하는데 참고가 되었습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다! 안 그래도 문제에 공간 복잡도를 더 줄일 수 있다고 적혀 있는데 잘 생각이 안나더라구요 ^^; 즐거운 연휴 보내세요!

@HerrineKim HerrineKim merged commit 5ce2b69 into DaleStudy:main Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants