-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipfile support and slow settings cache #720
base: master
Are you sure you want to change the base?
Conversation
Updated with smarter caching, also implements the functionality of what ENVIRON_HOOK_INVALID did before. |
If the interpreter configuration gets cached, how is the plugin gonna stop the running JsonServer and start a\ new one for the configured interpreter if the user changes it? This will force users to reopen their ST3 in order to update interpreter or path related options. Maybe we should use the Apart from that, I am pretty sure that we could be able to hook into pipenv as a library and don't use subprocess in order to check the path. Let me think about this for a while. |
But why would anyone change their interpreter settings while having an open session? Actually why would anyone change interpreter settings at all? There is just one interpreter per project, it actually never changes. We can absolutely use pipenv without subprocess but that'd mean including quite a lot of dependencies (about 20 MB right now):
|
You can open another project during the same session, I do it all the time |
But my solutions is caching it per view, so each project would naturally have it's own value. |
Also, there should really be only one subprocess per pipfile, this just needs to be fixed: |
I think the reference implementation for finding out virtualenv's location should be part of Pipfile specs. |
I love the idea of this PR in general, but I would take a different approach to implementation, separating the Perhaps we can start with just adding a few useful commands:
I'm going to experiment and if it looks good I'll submit a good PR. @ |
First try at Pipfile support and caching of
python_interpreter
,extra_paths
settings in a dict.