Clean up sloppy lexer code and test dependencies from initial implementation #2
+424
−556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the "code slop from first initial pass" by cleaning up repetitive patterns, removing dead code, and fixing test dependencies in the lexer implementation.
Changes Made
Lexer Improvements
try_match_scoped_variable()SILENT_BANG_LENGTH = 7ELLIPSIS_LENGTH = 3FUNCTION_KEYWORD_LENGTH = 8add_token(type, value)- standardizes token creationadvance_position(length)- handles position trackingTOKEN_TYPEShash had a keyword regex that conflicted with explicit keyword handlingTest Cleanup
pryrequirement that was causing test failuresprint_astmethod in spec_helper that had style violations and wasn't being usedCode Quality
Before/After Comparison
Before:
After:
Impact
The lexer functionality remains exactly the same - this is purely a cleanup refactor that makes the code more maintainable and removes the "late night session" technical debt.
Fixes #1.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.