redis-ha: fix busybox-ash-ism in redis_liveness.sh #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ${response:0:7} syntax is non-POSIX and not understood by Debian's
dash shell, so if a Debian-based Redis image is used the liveness check
breaks on slaves. A case statement makes this check more legible anyway,
in my opinion, and works in all the POSIX-compatible shells (busybox
ash, dash, and bash).
Signed-off-by: Chris Boot <bootc@bootc.net>
DandyDeveloper
previously approved these changes
Aug 26, 2024
|
@bootc Waiting on a separate PR to merge and I'll edit the chart patch to get the latest pushed out. Thank you! |
DandyDeveloper
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
${response:0:7}syntax is non-POSIX and not understood by Debian's dash shell, so if a Debian-based Redis image is used the liveness check breaks on slaves. A case statement makes this check more legible anyway, in my opinion, and works in all the POSIX-compatible shells (busybox ash, dash, and bash).Which issue this PR fixes
No issue created (yet).
Checklist
[stable/mychartname])