Add .Nil member to SymbolUntypedValue.type for nil#377
Closed
thetarnav wants to merge 1 commit intoDanielGavin:masterfrom
Closed
Add .Nil member to SymbolUntypedValue.type for nil#377thetarnav wants to merge 1 commit intoDanielGavin:masterfrom
.Nil member to SymbolUntypedValue.type for nil#377thetarnav wants to merge 1 commit intoDanielGavin:masterfrom
Conversation
Change symbol for `nil` from SymbolBasicValue to SymbolUntypedValue Enable semantic tokens for identifiers with SymbolBasicValue symbol value. Previously I disabled it (in DanielGavin#263) because `nil` was included there, which made it be highlighted as a type.
thetarnav
force-pushed
the
semantic-tokens-nil
branch
from
044477b to
7fd830b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change symbol for
nilfromSymbolBasicValuetoSymbolUntypedValueEnable semantic tokens for identifiers with
SymbolBasicValuesymbol value. Previously I disabled it (in #263) becausenilwas included there, which made it be highlighted as a type..Nilvariant is not entirely correct, becausenilcannot function as a value with "untyped type".It needs a concrete type.
So doing it properly would probably mean getting the type from the context.
Not sure.
Maybe instead of adding
.Nilvariant,nilshouldn't get any symbol? Since any declaration needs an explicit type, the symbol for the identifier will get it's type, from the type, not value. (Did that in #378)