Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more element type methods #8

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

EdVanDance
Copy link
Contributor

I went ahead and gave it a shot (#7) 😄

I'm not very experienced with Rust so please bare with me.

@DanielT
Copy link
Owner

DanielT commented Dec 28, 2024

Hi!
For "inexperienced with Rust" this is pretty good.
I'll merge it as-is, but later on I will probably change the sub_elements_spec() function into an iterator, to match the Rust implementation

@DanielT DanielT merged commit a546d05 into DanielT:main Dec 28, 2024
17 checks passed
@EdVanDance
Copy link
Contributor Author

Sounds fair to me. Thank you ☺️

@EdVanDance EdVanDance deleted the expose-more-element-type-methods branch January 10, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants