Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brazilian Portuguese (pt-BR) translation for Faction-Medieval p… #1758

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

MestreWilll
Copy link
Contributor

I've added a Brazilian Portuguese (pt-BR) translation for the Faction-Medieval plugin. The translation is contained in a new file within the language folder to support Portuguese-speaking users.

I believe this translation will help expand the user base of the plugin to those who prefer or need to play in Portuguese. Please review the changes, and let me know if there are any modifications or improvements needed.

Thank you for considering this contribution!

Best regards,
MestreWilll

dmccoystephenson and others added 2 commits July 7, 2023 08:15
Merging the latest release into the main branch.

---------

Co-authored-by: Ren Binden <ren.binden@gmail.com>
Co-authored-by: Donut <86391164+Chocolate1Donut@users.noreply.github.com>
@renbinden
Copy link
Member

Hi! Thanks for your work on this and your interest in sharing Medieval Factions with Brazilian Portuguese players!

Including translations in the main project is difficult, not because of the initial translation effort, but because by including a translation, we commit to maintaining it into the future, including all updates that may add additional functionality.
This increases the effort required to release new features, and means we spend time chasing translators who may have gone inactive since, or trying to find new speakers of the language. All in all, this means it's not something we like to do often.

I'd suggest you share your translation independently of the main Medieval Factions project, and update it after each new update comes out. This allows us to iterate quickly, and also makes the project accessible to Brazilian Portuguese speakers. Any translation files in the configuration folder will be recognised and can be set as a language in the main config.

@dmccoystephenson may have different opinions on this to me, so I'm open for a discussion.

We have spoken internally about building some functionality to allow downloading additional translations from in-game, but this has not come to fruition at this time.

@Unix-User
Copy link

Unix-User commented Sep 20, 2023

Ola, estou usando essa tradução em meu servidor, e me parece que a tradução esta muito boa com exceção de alguns bugs que planejo rastrear e corrigir em breve, obrigado pelo compartilhamento

Hi, I'm using this translation on my server, and it seems like the translation is very good with the exception of some bugs that I plan to track and fix soon, thanks for sharing

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support including this translation in the project. We can use online tools to translate messages and members of the community can correct any mistakes directly via contributing to the source code.

@dmccoystephenson dmccoystephenson changed the base branch from main to develop January 6, 2024 19:16
@dmccoystephenson dmccoystephenson dismissed their stale review January 6, 2024 19:16

The base branch was changed.

@dmccoystephenson
Copy link
Member

Modified base branch to develop

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @MestreWilll!

@dmccoystephenson dmccoystephenson merged commit 7168da8 into Dans-Plugins:develop Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants