Added convention based defaults and support for setting base path in API Gateway custom domain#2
Open
eric-swann-q2 wants to merge 38 commits intoDanteInc:masterfrom
Open
Added convention based defaults and support for setting base path in API Gateway custom domain#2eric-swann-q2 wants to merge 38 commits intoDanteInc:masterfrom
eric-swann-q2 wants to merge 38 commits intoDanteInc:masterfrom
Conversation
…se path can be set
BDCS-1630 Updated dependencies
BDCS-? Added capability to specify failover type
BDCS-1949 Allow the "DependsOn" for the ApiGatewayStubDeployment to be set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jgilbert01
First, thanks for this great project, it helped me a lot. I made several adjustments and figured I'd submit them to you for consideration. I believe that the existing configuration approach should continue to work though. I wanted the exact thing you had here but wanted to pull settings where possible rather than specify them and derive most things from a few settings. I've made the following additions:
If these changes don't work for you, not a big deal, but thought I'd submit the work I've done in case any of these things help. Thanks again for the plugin, it helped me immensely.