Fix linux <-> windows path relocation issue #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes paths which did not contain the given root dir still made it past line 72; when relocation was attempted, the path wasn't fundamentally changed, BUT in the case of posix/windows relocation, the forwardslashes were changed to backslash. For repeated relocation of multiple folders to different places, this meant all paths not matched by the first relocation were all set to have backslash separators, meaning they are permanently unrelocatable by the subsequent relocations, since they are still looking for backslashes. The conditional that was supposed to detect this was broken, I fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes paths which did not contain the given root dir still made it past line 72; when relocation was attempted, the path wasn't fundamentally changed, BUT in the case of posix/windows relocation, the forwardslashes were changed to backslash. For repeated relocation of multiple folders to different places, this meant all paths not matched by the first relocation were all set to have backslash separators, meaning they are permanently unrelocatable by the subsequent relocations, since they are still looking for backslashes. The conditional that was supposed to detect this was broken, I fixed it