-
Notifications
You must be signed in to change notification settings - Fork 0
Update tag_and_release.yml #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Reviewer's GuideRefactor the tag_and_release workflow to trigger only on tag pushes, tighten permissions, restructure the release job, and switch from the actions/create-release action to a GitHub CLI invocation. Flow diagram for new release creation process in workflowflowchart TD
Start([Start: Tag push event]) --> Step1["Trigger tag_and_release workflow"]
Step1 --> Step2["Run release job"]
Step2 --> Step3["Set GITHUB_TOKEN and tag variables"]
Step3 --> Step4["Run gh release create command"]
Step4 --> End([End: Release created])
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying uniswap with
|
| Latest commit: |
5352be4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d3b2fb16.uniswap-omj.pages.dev |
| Branch Preview URL: | https://dargon789-patch-2.uniswap-omj.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and found some issues that need to be addressed.
- The workflow is invalid YAML because you’ve nested
on:andjobs:inside a step—move them to the top level of the file. - Add a step to install or configure the GitHub CLI (for example using actions/setup-gh) before running
gh release create. - Include an
actions/checkoutstep so that the GitHub CLI has the correct repository context when creating the release.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The workflow is invalid YAML because you’ve nested `on:` and `jobs:` inside a step—move them to the top level of the file.
- Add a step to install or configure the GitHub CLI (for example using actions/setup-gh) before running `gh release create`.
- Include an `actions/checkout` step so that the GitHub CLI has the correct repository context when creating the release.
## Individual Comments
### Comment 1
<location> `.github/workflows/tag_and_release.yml:38-40` </location>
<code_context>
- uses: actions/create-release@8e3b4a5e184b498423d5b25ca5ceb5a9258c92c2
+ - name: 🪽 Create release
+
+ on:
+ push:
+ tags:
+ - v*
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Workflow triggers are misplaced inside a job definition.
Move the 'on:' block to the root of the workflow file to ensure proper triggering.
</issue_to_address>
### Comment 2
<location> `.github/workflows/tag_and_release.yml:43-44` </location>
<code_context>
+ tags:
+ - v*
+
+ permissions:
+ contents: write
+
+ jobs:
</code_context>
<issue_to_address>
**issue (bug_risk):** Permissions block is incorrectly nested under workflow triggers.
Move the 'permissions:' block outside of the 'on:' block to avoid YAML parsing errors and ensure permissions are applied correctly.
</issue_to_address>
### Comment 3
<location> `.github/workflows/tag_and_release.yml:46-47` </location>
<code_context>
+ permissions:
+ contents: write
+
+ jobs:
+ release:
+ name: Release pushed tag
+ runs-on: ubuntu-24.04
</code_context>
<issue_to_address>
**issue (bug_risk):** Job definitions are incorrectly nested under a job.
Move the 'jobs:' block to the top level of the workflow file to ensure correct execution.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Summary by Sourcery
Overhaul the tag_and_release workflow to trigger on v* tag pushes, adjust permissions, and use the GitHub CLI for creating releases
CI: