Swaps clan faction assignment to clan. Fixes a few NPCS not having AI controllers#730
Open
FalloutFalcon wants to merge 4 commits intoDarkPack13:masterfrom
Open
Swaps clan faction assignment to clan. Fixes a few NPCS not having AI controllers#730FalloutFalcon wants to merge 4 commits intoDarkPack13:masterfrom
FalloutFalcon wants to merge 4 commits intoDarkPack13:masterfrom
Conversation
XeonMations
requested changes
Feb 26, 2026
Collaborator
XeonMations
left a comment
XeonMations
left a comment
There was a problem hiding this comment.
remove the add factions, dont comment them out
…o szchlata-fight-back
Member
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #720
Why It's Good For The Game
The old code is very inconsistent on when its a clan vs a disc that assigns it. Neither remove it if lost. The IDs are based on clan so if you want a monster to be bound based on disc, it should use a different faction but this is already mostly made redundant via beastmaster code.
Changelog
🆑
fix: Assignment of a faction ID was moved to the clan rather then discipline
fix: Fixes a few NPCS not having AI controllers
fix: Lasombra aren't hidden in ALL vis contents (like virtual z)
/:cl: