Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHO IS JOHN NECRA WHY DOES HE WEAR THE MASK #1187

Closed
wants to merge 9 commits into from

Conversation

YuiY1997
Copy link
Contributor

@YuiY1997 YuiY1997 commented Nov 30, 2024

About The Pull Request

Makes the new unique Necra cleric mask a mask

Moves the deathmask sprite to the appropriate folder

Why It's Good For The Game

Allows the equipping of helmets while wearing it. It's a good unique item, but is basically outclassed by every helmet in the game.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

test

makes the mask use the mask slot so helmets could be equipped
@YuiY1997
Copy link
Contributor Author

YuiY1997 commented Nov 30, 2024

I didn't know there were any that were mapped lmao uh oh

edit: looks like it's only on dun manor

removes the death mask that was mapped into dun manor since it is now a different item and was preventing the map from compiling

armor = ARMOR_WEAK
prevent_crits = MINOR_CRITICALS

//................ Death Shroud ............... // - Necra headwear that conceals indentity
/obj/item/clothing/head/roguetown/padded/deathshroud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how there's two deathshrouds, so fucking bleak.

@BadAtThisGame302
Copy link
Contributor

Need to remove that one too and replace it aswell.

@YuiY1997
Copy link
Contributor Author

Need to remove that one too and replace it aswell.

image

Donezo

@YuiY1997
Copy link
Contributor Author

image
goes hard with armor

unintended consequences of my actions
@YuiY1997
Copy link
Contributor Author

okay so the item was on a bunch of maps I didn't know about. Fixed.

@NPC1314
Copy link
Contributor

NPC1314 commented Nov 30, 2024

on one hand it does make sense and it doesnt look bad, on the other it kinda breaks with the whole "all priests/acolytes supposed to wear their unique headgear to make them visually distinct"
Need to give this one a thonk.

@YuiY1997
Copy link
Contributor Author

YuiY1997 commented Nov 30, 2024

on one hand it does make sense and it doesnt look bad, on the other it kinda breaks with the whole "all priests/acolytes supposed to wear their unique headgear to make them visually distinct" Need to give this one a thonk.

Well a lot of the Necra Acolyte stuff was just moved to gravedigger anyway so that's worth taking into consideration. It also doesn't at all change the appearance of anything, only the slot it is on.

This actually might be an opportunity to make a proper priest mask for them.

@YuiY1997
Copy link
Contributor Author

YuiY1997 commented Nov 30, 2024

Look, ping me on discord when you make a decision on if this is okay or not and we'll merge it then.

This has both map changes and sprite changes because it's removing an item and it already has conflicts. I'll resubmit without conflicts after you have made a decision.

@YuiY1997 YuiY1997 closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants